[Draft][CX-CLEANUP] - DA Integrated Storage #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
changed the title
jparr721
commented
Mar 15, 2024
| @@ -59,7 +59,7 @@ futures = "0.3.30" | |||
| # TODO generic-array should not be a direct dependency | |||
| # https://github.com/EspressoSystems/HotShot/issues/1850 | |||
| generic-array = { version = "0.14.7", features = ["serde"] } | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/hotshot-types", tag = "0.1.4" } | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/hotshot-types", branch = "jparr721/issue-2621" } | |||
There was a problem hiding this comment.
Tracking: EspressoSystems/hotshot-types#15
jparr721
requested review from
lukaszrzasik,
elliedavidson and
bfish713
as code owners
jparr721
requested review from
shenkeyao,
bfish713,
jbearer and
elliedavidson
and removed request for
bfish713,
lukaszrzasik and
elliedavidson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2621
We want to integrate a persistent storage interface within HotShot to enable the application to manage data storage effectively. This feature aims to address potential data storage issues (e.g., full disk space) that can prevent nodes from storing DA blobs or VID shares.
This PR:
BlockStorageTraitBlockStoragein HotShot's initself.consensus.write().await.vid_shares.insert(view, disperse.clone());call from the code for VID disperse events.This code also implements a number of changes to introduce a
TestBlockStoragetype for use in the various testing components.This PR does not:
Key places to review: