Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TaskError structs #2637

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Remove unused TaskError structs #2637

merged 1 commit into from
Feb 22, 2024

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Feb 22, 2024

No linked issue.

This PR:

@shenkeyao pointed out that ConsensusTaskError in upgrade.rs was misnamed, and could probably be deleted anyway. This seems to be the case for the other tasks too.

The ***TaskError structs are now removed, since they appear to be completely unused.

This PR does not:

Key places to review:

The task files in task-impls.

@ss-es ss-es merged commit 3c80a34 into main Feb 22, 2024
13 checks passed
@ss-es ss-es deleted the ss/task-impls-cleanup branch February 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants