Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_CLEANUP] Integrate new Task, in the code and remove the old #2493

Merged
merged 34 commits into from
Feb 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3cb5652
lint up to missing docs in task-impls
bfish713 Jan 25, 2024
1500c9e
All builds but the tests~
bfish713 Jan 26, 2024
fa647ed
All builds but the tests in testing
bfish713 Jan 30, 2024
ad49d46
linting
bfish713 Jan 30, 2024
4def208
Test can run, but they fail
bfish713 Jan 30, 2024
76e1590
some fixes
bfish713 Jan 30, 2024
da50e0a
cargo fix
bfish713 Jan 30, 2024
224fdb1
replace broadcast with broadcast_direct
bfish713 Jan 31, 2024
016b36a
test almost running correctly, maybe not passing
bfish713 Jan 31, 2024
b30effd
Add Tasks to project, success test passes
bfish713 Jan 31, 2024
81a8e4d
test can pass
bfish713 Jan 31, 2024
4e1718f
fixing tests, basic passes except unit tests
bfish713 Jan 31, 2024
d37c03d
fixed consensus task test
bfish713 Jan 31, 2024
31dfea7
fixing other task tests
bfish713 Jan 31, 2024
2b39c50
Remove more cruft
bfish713 Jan 31, 2024
a7cdad9
replace event sending with helper for better errors
bfish713 Jan 31, 2024
81871b4
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Jan 31, 2024
b56f870
lint after merge
bfish713 Jan 31, 2024
ca58069
fixing unit tests and lints for both async types
bfish713 Jan 31, 2024
7350604
remove superfluous log and fix doc
bfish713 Feb 1, 2024
1c24942
Remove Cargo.lock from tasks
bfish713 Feb 1, 2024
992f6b6
cleanup
bfish713 Feb 1, 2024
303aca3
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Feb 1, 2024
8a0dec0
Addressing comments
bfish713 Feb 6, 2024
5c9c19d
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Feb 6, 2024
e276c1b
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Feb 7, 2024
e0065a0
Update tasks based on feedback
bfish713 Feb 7, 2024
a02f0ec
remove outdated # Panics doc comments
bfish713 Feb 7, 2024
93e7913
missed on # Panics
bfish713 Feb 7, 2024
e8cba7f
Reveiw comments minus filters
bfish713 Feb 9, 2024
f200a95
Lower a log level, fix task/cargo.toml
bfish713 Feb 9, 2024
edc820a
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Feb 9, 2024
2fefff5
Remove todo
bfish713 Feb 9, 2024
6c28e15
Merge remote-tracking branch 'origin/main' into bf/new-task-design
bfish713 Feb 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test-sequencer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
hotshot-state-prover = { path = "${GITHUB_WORKSPACE}/hotshot/crates/hotshot-state-prover" }
hotshot-orchestrator = { path = "${GITHUB_WORKSPACE}/hotshot/crates/orchestrator" }
hotshot-web-server = { path = "${GITHUB_WORKSPACE}/hotshot/crates/web_server" }
hotshot-task = { path = "${GITHUB_WORKSPACE}/hotshot/crates/task" }
hotshot-task-impls = { path = "${GITHUB_WORKSPACE}/hotshot/crates/task-impls" }
hotshot-testing = { path = "${GITHUB_WORKSPACE}/hotshot/crates/testing" }
hotshot-types = { path = "${GITHUB_WORKSPACE}/hotshot/crates/types" }
Expand Down
48 changes: 27 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ ark-ed-on-bn254 = "0.4"
ark-ff = "0.4"
ark-serialize = "0.4"
ark-std = { version = "0.4", default-features = false }
async-broadcast = "0.6.0"
async-compatibility-layer = { git = "https://github.com/EspressoSystems/async-compatibility-layer.git", tag = "1.4.1", default-features = false, features = [
"logging-utils",
] }
task = { git = "https://github.com/EspressoSystems/HotShotTasks.git" }
async-lock = "2.8"
async-trait = "0.1.77"
bincode = "1.3.3"
Expand Down
3 changes: 3 additions & 0 deletions crates/constants/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@ pub struct Version {

/// Constant for protocol version 0.1.
pub const VERSION_0_1: Version = Version { major: 0, minor: 1 };

/// Default Channel Size for consensus event sharing
pub const EVENT_CHANNEL_SIZE: usize = 100_000;
3 changes: 2 additions & 1 deletion crates/hotshot/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ name = "orchestrator-combined"
path = "examples/combined/orchestrator.rs"

[dependencies]
async-broadcast = { workspace = true }
async-compatibility-layer = { workspace = true }
async-lock = { workspace = true }
async-trait = { workspace = true }
Expand All @@ -96,7 +97,6 @@ hotshot-web-server = { version = "0.1.1", path = "../web_server", default-featur
hotshot-orchestrator = { version = "0.1.1", path = "../orchestrator", default-features = false }
hotshot-types = { path = "../types", version = "0.1.0", default-features = false }
hotshot-utils = { path = "../utils" }
hotshot-task = { path = "../task", version = "0.1.0", default-features = false }
hotshot-task-impls = { path = "../task-impls", version = "0.1.0", default-features = false }
libp2p-identity = { workspace = true }
libp2p-networking = { workspace = true }
Expand All @@ -108,6 +108,7 @@ time = { workspace = true }
derive_more = "0.99.17"
portpicker = "0.1.1"
lru = "0.12.2"
hotshot-task = { path = "../task" }

tracing = { workspace = true }

Expand Down
5 changes: 2 additions & 3 deletions crates/hotshot/examples/infra/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use hotshot_orchestrator::{
client::{OrchestratorClient, ValidatorArgs},
config::{NetworkConfig, NetworkConfigFile, WebServerConfig},
};
use hotshot_task::task::FilterEvent;
use hotshot_testing::{
block_types::{TestBlockHeader, TestBlockPayload, TestTransaction},
state_types::TestInstanceState,
Expand Down Expand Up @@ -393,7 +392,7 @@ pub trait RunDA<
/// Starts HotShot consensus, returns when consensus has finished
async fn run_hotshot(
&self,
mut context: SystemContextHandle<TYPES, NODE>,
context: SystemContextHandle<TYPES, NODE>,
transactions: &mut Vec<TestTransaction>,
transactions_to_send_per_round: u64,
) {
Expand All @@ -413,7 +412,7 @@ pub trait RunDA<
error!("Starting HotShot example!");
let start = Instant::now();

let (mut event_stream, _streamid) = context.get_event_stream(FilterEvent::default()).await;
let mut event_stream = context.get_event_stream();
let mut anchor_view: TYPES::Time = <TYPES::Time as ConsensusTime>::genesis();
let mut num_successful_commits = 0;

Expand Down
Loading