[Tech Debt] Move task-impls to hotshot
#2452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinI
force-pushed
the
ag/move-task-impls-to-hotshot
branch
from
d94bfee to
0f874e0
Compare
QuentinI
requested review from
shenkeyao,
elliedavidson and
bfish713
as code owners
|
@shenkeyao can you re-approve please? Had to merge main since GitHub complained about conflicts |
|
Nevermind, this somehow breaks unreliable_networks tests after I merged in main, I'll need to fix it |
shenkeyao
previously approved these changes
Jan 26, 2024
|
Since this already has some conflicts can we hold off on this until: #2500 is merged since it changes so much in task_impls |
|
This is unblocked now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2294
This PR:
Demotes
task-implsfrom a crate to a part ofhotshotThis PR does not:
include any additional refactorings
Key places to review:
hotshot::taskssubmodule, which is wheretask-implswas moved.