[TESTS] - View Sync Testing Harness Callback #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieracDelta
changed the title
bfish713
previously approved these changes
Jan 8, 2024
bfish713
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2285
This PR:
This PR adds a view sync check to ensure that certain nodes did have view sync activated during the test run.
This PR does not:
Add any substantial tests using this feature. It would be worth discussing what sort of tests should make use of this feature.
Key places to review:
Worth confirming that
ViewSyncTaskDescriptionmatches the sort of API we want to specify nodes hitting view sync