Check for Genesis before Clearing payload_commitment_and_metadata
#2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
requested review from
jbearer,
shenkeyao,
elliedavidson and
rob-maron
bfish713
changed the title
payload_commitment_and_metadata
rob-maron
previously approved these changes
Dec 22, 2023
jbearer
reviewed
Dec 22, 2023
crates/task-impls/src/consensus.rs
Outdated
Comment on lines
241
to
244
| let genesis_commitment = vid_commitment( | ||
| &genesis_payload.encode().unwrap().collect(), | ||
| self.quorum_membership.total_nodes(), | ||
| ); |
There was a problem hiding this comment.
We are computing an extraneous VID commitment every time we receive a vote? We need to cache this somewhere. Or we could add an explicit is_genesis flag to payload_commitment_and_metadata, since we should know at the time we set this whether it is the genesis or not
There was a problem hiding this comment.
This only happens if the proposal is for view 1 and the genesis flag on the justify QC is set. So it only happens in the first round of voting
There was a problem hiding this comment.
We could add a flag to remove this check
rob-maron
approved these changes
Dec 22, 2023
Same, passed on the last commit and this should improve things |
jbearer
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes a race condition where a node could get it's VID payload commit and metadata before it got the first proposal with genesis qc justification and then would clear the correct data and cause it to not propose.
This PR does not:
Key places to review:
The fix, and in general if the flow of clearing this variable which is set on task creation makes sense