Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX_CI] - Fix catchup tests #2254

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[FIX_CI] - Fix catchup tests #2254

merged 4 commits into from
Dec 19, 2023

Conversation

shenkeyao
Copy link
Member

@shenkeyao shenkeyao commented Dec 18, 2023 •
edited
Loading

Closes #2215.

This PR:

  • Fixes test_catchup.
  • Reenables test_catchup_one_node and test_catchup_in_view_sync and fixes them.
  • Adds stricter num_failued_views requirements to catchup tests.

This PR does not:

  • Fix test_catchup_web, which is related to web server test failure.
  • Fix other CI failures.

Key places to review:

All changes.

@shenkeyao shenkeyao changed the title Fix catchup tests [FIX_CI] - Fix catchup tests Dec 18, 2023
@shenkeyao shenkeyao merged commit e5458f5 into main Dec 19, 2023
8 of 9 checks passed
@shenkeyao shenkeyao deleted the keyao/ci-catchup branch December 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfish713 bfish713 bfish713 approved these changes

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@QuentinI QuentinI Awaiting requested review from QuentinI

@rob-maron rob-maron Awaiting requested review from rob-maron

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX_CI] - Investigate and fix catchup on CI
2 participants
@shenkeyao @bfish713