[Stability] Poll for latest view sync cert #2246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2245
This PR:
Adds polling for the latest view sync cert.
Some creative liberties to note:
Everything else is about the same as the "PollForRecentProposal" things from @bfish713.
This PR does not:
Change or update the view sync replicas or tasks, only the networking.
Key places to review:
Everything in
view_sync.rs
. To me it is, but I want to be sure the logic to start/stop the poll is sufficient.I have run a bunch of manual view sync tests to make sure that we start/stop this polling when necessary, and also that unique certs it pulls are processed properly. I'm not sure if there are any more advanced tests I should run, please let me know!