Reduce Logging Level in Many Places #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
requested review from
dailinsubjam,
shenkeyao,
elliedavidson and
rob-maron
There was a problem hiding this comment.
Can we also alter some logging in the view sync task? Specifically, I'd like to error log when view sync in triggered and when it completed, but reduce all the other logs to warn or lower. For example "Vote sending timed out" and similar logs don't need to be error level.
rob-maron
previously approved these changes
Dec 13, 2023
elliedavidson
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Lower logs to appropriate levels
This PR does not:
change any functionality/features
Key places to review:
If I'm changing to the correct level and if I missed any logs that should be lowered.