Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stability] Config file changes #2219

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[Stability] Config file changes #2219

merged 3 commits into from
Dec 14, 2023

Conversation

rob-maron
Copy link
Collaborator

@rob-maron rob-maron commented Dec 13, 2023 •
edited
Loading

This PR:

  • Moves the path creation to to_file
  • Adds an error type to be more verbose
  • Changes format from bincode to JSON

This PR does not:

Change any functionality at all

@rob-maron rob-maron changed the title [Quick change] Move config file creation to to_file [Quick change] Move config folder creation to to_file Dec 13, 2023
bfish713
bfish713 previously approved these changes Dec 13, 2023
View reviewed changes
@rob-maron rob-maron changed the title [Quick change] Move config folder creation to to_file [Stability] Config file changes Dec 13, 2023
dailinsubjam
dailinsubjam approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dailinsubjam dailinsubjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rob-maron
Copy link
Collaborator Author

Tested these changes locally for serializing and deserializing from json ✅

@rob-maron rob-maron merged commit e35bc13 into main Dec 14, 2023
9 checks passed
@rob-maron rob-maron deleted the rm/move-config-file-creation branch December 14, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dailinsubjam dailinsubjam dailinsubjam approved these changes

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@shenkeyao shenkeyao Awaiting requested review from shenkeyao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rob-maron @bfish713 @dailinsubjam