Add issue and PR templates #2097
Conversation
| <!-- * file.rs, `add_integers` function --> | ||
|
|
||
| ### How to test this PR: | ||
| <!-- * E.g. `just async_std test` --> |
There was a problem hiding this comment.
Are we expecting the reviewer to run the tests? I think we could skip this "How to test" section if no manual testing is needed and we could just use the CI results.
There was a problem hiding this comment.
That's fair! Perhaps I'll leave it as an optional field.
|
|
||
| <!-- Complete the following items before creating this PR | ||
| * Are the proper people tagged to review it? | ||
| * Have you listed yourself as the assignee? |
There was a problem hiding this comment.
I'm wondering if this is necessary since the PR author is usually the same as the assignee. I think the author is also a filter attribute if we want to search for and filter PRs on GitHub.
There was a problem hiding this comment.
This was something @dailinsubjam brought up. I am fine either way. :)
There was a problem hiding this comment.
I think this could help but not necessary, assignee's avatar will appear right after PR on the searching board which might be easier to find, but looks like we can also filter PR by selecting the author.
There was a problem hiding this comment.
Yeah I thought it made sense when it was brought up in the meeting yesterday! But on second thought, it's probably not necessary?
There was a problem hiding this comment.
Okay, I'll remove it!
There was a problem hiding this comment.
@dailinsubjam and @shenkeyao here is the new PR: #2103
There was a problem hiding this comment.
Approved there. Thanks Ellie!
No description provided.