-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotshot-state-prover] proof generation #2055
Conversation
…into chengyu-proofgen
This PR is ready for view. cc @alxiong @chancharles92
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good work!
Apart from concrete comments, I'd like to see better/clearer organization of bad path in circuit tests.
e.g. let bit_masked_sig = |sigs| { .. }
could be an internal lambda function, and can summarize some helper function to make the test code reads more smoothly.
^^ just my opinion, improve at @mrain's discretion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to change block_comm
name as it is wrong, (both in this PR and in types/traits/state.rs
suggestions:
block_comms_root
block_comm_history_root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
closes: #1985
I tried but cannot make functions generics because of the StakeTable trait bounds. It's too complicated.
The tests are not implemented yet for srs problem. I'm handling it now.