Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel polling for retrieved items #2031

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Cancel polling for retrieved items #2031

merged 3 commits into from
Nov 14, 2023

Conversation

rob-maron
Copy link
Collaborator

No description provided.

@rob-maron rob-maron marked this pull request as ready for review November 9, 2023 21:02
shenkeyao
shenkeyao previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bfish713
bfish713 requested changes Nov 10, 2023
View reviewed changes
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
@rob-maron rob-maron merged commit 15377d1 into develop Nov 14, 2023
6 checks passed
@rob-maron rob-maron deleted the rm/cancel-polling branch November 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenkeyao shenkeyao shenkeyao approved these changes

@bfish713 bfish713 bfish713 approved these changes

@elliedavidson elliedavidson Awaiting requested review from elliedavidson elliedavidson is a code owner

@DieracDelta DieracDelta Awaiting requested review from DieracDelta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rob-maron @bfish713 @shenkeyao