Remove Old Vote and QC for all but View sync #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
previously approved these changes
Nov 8, 2023
| .publish(HotShotEvent::TimeoutVoteSend(vote)) | ||
| .await; | ||
| } | ||
| Ok(Some(_vote_token)) => { |
There was a problem hiding this comment.
Do we plan to refactor make_vote_token so that it won't return an unused vote_token anymore? No need to make the change in this PR though.
There was a problem hiding this comment.
Yeah that's exactly the plan. I'm working on that at the moment, will be the next PR
bfish713
dismissed
shenkeyao’s stale review
The merge-base changed after approval.
rob-maron
previously approved these changes
Nov 9, 2023
bfish713
dismissed
rob-maron’s stale review
The merge-base changed after approval.
rob-maron
approved these changes
Nov 9, 2023
shenkeyao
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.