Integrate VID Vote and Cert #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
requested review from
dailinsubjam,
shenkeyao,
elliedavidson and
rob-maron
shenkeyao
previously approved these changes
Nov 7, 2023
crates/task-impls/src/network.rs
Outdated
| MessageKind::<TYPES, I>::from_consensus_message(SequencingMessage(Right( | ||
| CommitteeConsensusMessage::VidVote(vote.clone()), | ||
| ))), | ||
| TransmitType::Direct, | ||
| Some(membership.get_leader(vote.get_view())), // TODO who is VID leader? https://github.com/EspressoSystems/HotShot/issues/1699 | ||
| Some(membership.get_leader(vote.get_view_number())), // TODO who is VID leader? https://github.com/EspressoSystems/HotShot/issues/1699 |
There was a problem hiding this comment.
Nit: We could remove this TODO since the linked issue has been closed.
| .unwrap() | ||
| .unwrap(); | ||
| let vid_vote = vid_exchange.create_vid_message(block.commit(), ViewNumber::new(2), vote_token); | ||
| let vid_vote = VIDVote2::create_signed_vote( |
There was a problem hiding this comment.
So nice that the vote token + message creation are now combined into one function. 👍
dailinsubjam
approved these changes
Nov 8, 2023
shenkeyao
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2013