Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create New Cert, Vote, and Vote Accumulator types #1961

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Create New Cert, Vote, and Vote Accumulator types #1961

merged 4 commits into from
Oct 30, 2023

Conversation

bfish713
Copy link
Collaborator

Adds new traits for Vote and Certificate and uses them to implement as generic vote accumulator.

elliedavidson
elliedavidson approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@elliedavidson elliedavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@bfish713 bfish713 merged commit 1651a53 into develop Oct 30, 2023
4 of 5 checks passed
@bfish713 bfish713 deleted the bf/new-cert-types branch October 30, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliedavidson elliedavidson elliedavidson approved these changes

@DieracDelta DieracDelta Awaiting requested review from DieracDelta

@shenkeyao shenkeyao Awaiting requested review from shenkeyao

@rob-maron rob-maron Awaiting requested review from rob-maron rob-maron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfish713 @elliedavidson