Ed/timeout hotfix merge #1872
Merged
Ed/timeout hotfix merge #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase DAC logging
* Decrease network task polling frequency from 500ns to 100ms * Fix format * increase webserver test duration --------- Co-authored-by: Rob <[email protected]>
Remove nonzero check for view sync indices
Subscribe to web server when starting view sync
Update loggings
Update consensus state even if missing parent info
shenkeyao
approved these changes
Oct 9, 2023
| { | ||
| // Validate the block commitment for non-genesis DAC. | ||
| if !cert.is_genesis() && cert.leaf_commitment() != proposal.block_commitment { |
There was a problem hiding this comment.
is_genesis always returns false so is redundant. But the fact that it always returns false might be an issue. I'll make a GH issue for further discussion/fix, so no need to change anything, just a heads-up. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the changes in the 'ed/timeout-hotfix' branch into `main'
Also updates Nix flake for the new MacOS update