fix: revert to using fixed val for transactions #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
changed the title
shenkeyao
reviewed
Sep 29, 2023
| let mut bytes = vec![0; RANDOM_TX_BASE_SIZE + (padding as usize)]; | ||
| rng.fill_bytes(&mut bytes); | ||
| VIDTransaction(bytes) | ||
| VIDTransaction(vec![0; RANDOM_TX_BASE_SIZE + (padding as usize)]) |
There was a problem hiding this comment.
I thought without the randomness, there was a test failure. Was it fixed?
There was a problem hiding this comment.
Yeah, I think the implementing the nonstatic commit() for VID fixed this :)
shenkeyao
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI for async_std is operating with odd behavior with the randomness