Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block payload and VID disperse #1814

Merged
merged 20 commits into from
Sep 27, 2023
Merged

Refactor block payload and VID disperse #1814

merged 20 commits into from
Sep 27, 2023

Conversation

shenkeyao
Copy link
Member

@shenkeyao shenkeyao commented Sep 25, 2023 •
edited
Loading

  • Updates VIDBlockPayload.
    • Adds VID commitment.
    • Updates Committable impl for VIDBlockPayload.
  • Removes add_transaction_raw from BlockPayload trait.
  • Updates VID disperse.
    • Moves the construction from the DA task to the transaction task.
    • Gets VID first, then the block and proposal.
    • Uses transaction bytes instead of message bytes for VID construction.

Closes #1787.
Closes #1588.

jbearer
jbearer reviewed Sep 25, 2023
View reviewed changes
crates/hotshot/src/demo.rs Show resolved Hide resolved
crates/hotshot/src/lib.rs Show resolved Hide resolved
ggutoski
ggutoski reviewed Sep 25, 2023
View reviewed changes
crates/types/src/block_impl.rs Outdated Show resolved Hide resolved
crates/types/src/block_impl.rs Show resolved Hide resolved
crates/types/src/block_impl.rs Show resolved Hide resolved
crates/types/src/traits/block_contents.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
crates/testing/tests/atomic_storage.rs Show resolved Hide resolved
@shenkeyao shenkeyao mentioned this pull request Sep 26, 2023
Closed
@shenkeyao
Copy link
Member Author

PR comments have been addressed. I'll sync with main and resolve merge conflicts later.

@shenkeyao shenkeyao requested a review from ggutoski September 27, 2023 18:55
@shenkeyao shenkeyao merged commit 26e2451 into main Sep 27, 2023
@shenkeyao shenkeyao deleted the keyao/refactor-payload branch September 27, 2023 20:58
@ggutoski ggutoski mentioned this pull request Oct 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbearer jbearer jbearer left review comments

@ggutoski ggutoski ggutoski approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@rob-maron rob-maron Awaiting requested review from rob-maron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shenkeyao @ggutoski @jbearer