Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Kademlia cache to disk #1773

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Persist Kademlia cache to disk #1773

merged 5 commits into from
Sep 25, 2023

Conversation

rob-maron
Copy link
Collaborator

aims to close issue #673

@rob-maron rob-maron marked this pull request as draft September 18, 2023 21:51
@rob-maron
Copy link
Collaborator Author

rob-maron commented Sep 18, 2023

It's failing some tests right now, so drafting this

Error is due to the cache being used in multiple test runs, which are invalid between each other

EDIT: resolved

@rob-maron rob-maron marked this pull request as ready for review September 19, 2023 14:12
DieracDelta
DieracDelta previously approved these changes Sep 23, 2023
Copy link
Contributor

@DieracDelta DieracDelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work.

@rob-maron rob-maron merged commit f6cac67 into main Sep 25, 2023
@rob-maron rob-maron deleted the rm/persist-libp2p-state branch September 25, 2023 23:50
rob-maron added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants