Integrate aggregate signature + bit-vector QC validation trait + public hotshot-primitive repo + change signature scheme

[dailinsubjam]

Trying PR, a minor change on the signature scheme: from BLSSignatureScheme to BLSOverBN254CurveSignatureScheme.

[CLAassistant]

All committers have signed the CLA.

[philippecamacho]

I have got this error when I try to run the tests:

> nix-shell
> RUST_LOG=$ERROR_LOG_LEVEL RUST_LOG_FORMAT=$ERROR_LOG_FORMAT cargo test --verbose --release --lib --bins --tests --benches --features=full-ci --workspace -- --nocapture --test-threads=1
...
error[E0432]: unresolved import `hotshot::traits::election::vrf::VrfImpl`
 --> testing/tests/centralized_server.rs:5:51
  |
5 |     election::{static_committee::StaticCommittee, vrf::VrfImpl},
  |                                                   ^^^^^^^^^^^^ no `VrfImpl` in `traits::election::vrf`

error[E0432]: unresolved import `hotshot_testing::test_types::VrfTestTypes`
  --> testing/tests/centralized_server.rs:10:44
   |
10 |     test_types::{StaticCommitteeTestTypes, VrfTestTypes},
   |                                            ^^^^^^^^^^^^ no `VrfTestTypes` in `test_types`

warning: unused import: `signatures::BLSSignatureScheme`
  --> testing/tests/centralized_server.rs:21:21
   |
21 | use jf_primitives::{signatures::BLSSignatureScheme, vrf::blsvrf::BLSVRFS...
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `KeyPair`
  --> testing/tests/centralized_server.rs:23:83
   |
23 | ...OverBN254CurveSignatureScheme, KeyPair};
   |                                   ^^^^^^^

For more information about this error, try `rustc --explain E0432`.
warning: `hotshot-testing` (test "centralized_server") generated 2 warnings
error: could not compile `hotshot-testing` due to 2 previous errors; 2 warnings emitted

[shenkeyao]

Looks good! Only minor comments.

[shenkeyao]

Oh, one more minor thing: you could remove your name from comments that are notes rather than todos. I thought Sishan NOTE were all TODOs, then realized they were just code comments. 😄

[dailinsubjam]

Oh, one more minor thing: you could remove your name from comments that are notes rather than todos. I thought Sishan NOTE were all TODOs, then realized they were just code comments. 😄

Agree! I've removed them and also update the comments.

[DieracDelta]

This looks great! Phenomenal job! Couple of minor thoughts,

[alxiong]

@dailinsubjam I have some more API changes to stake table (EspressoSystems/hotshot-primitives#66 soon to be merged). and I feel that maybe it's time to move the entire stake_table code from hotshot-primitives to HotShot now. what's your opinion?
(do you prefer to merge this first, and then move stake_table later; OR move now and you modify this PR further for the updated API?)

[dailinsubjam]

@dailinsubjam I have some more API changes to stake table (EspressoSystems/hotshot-primitives#66 soon to be merged). and I feel that maybe it's time to move the entire stake_table code from hotshot-primitives to HotShot now. what's your opinion? (do you prefer to merge this first, and then move stake_table later; OR move now and you modify this PR further for the updated API?)

Thanks for letting me know! I'm working along the merge, and also using one branch of hotshot-primitives which has some of my minor changes (basically changing the version dependency and adding traits like clone, and debug), it may need some time (but not too much) to merge my changes with your changes if I transfer to the newest version of hotshot-primitives.

I might move on at this point (hopefully finish the merge on hotshot today or this weekend) and once you finished the stake_table merge we can do these at the same time: integrate my changes to hotshot-primitives or merge your changes to my hotshot-primitives branch, and dealing with the remaining merging issues on hotshot. Does that sound good to you?

Edit: This is not in a hurry until our branch on hotshot be merged into main, since now I'm also merging my changes to a branch of hotshot. But will definitely add it ASAP once it's ready.