[no ci] link to #1695

EspressoSystems · Sep 8, 2023 · b4a5dc1 · b4a5dc1
1 parent cf20099
commit b4a5dc1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/crates/task-impls/src/events.rs b/crates/task-impls/src/events.rs
@@ -69,8 +69,6 @@ pub enum SequencingHotShotEvent<TYPES: NodeType, I: NodeImplementation<TYPES>> {
     /// Vid disperse data has been received from the network; handled by the DA task
     ///
     /// Like [`DAProposalRecv`].
-    /// TODO GG: lots of boilerplate here eg. `VidDisperse[Send|Recv]`. If we need both [Send|Recv] then maybe partition [`SequencingHotShotEvent`] into separate enums?
-    /// TODO GG: should [`VidDisperse`] be of the form [`Proposal<DAProposal<TYPES>>`] to mirror [`DAProposalRecv`]? We need things like `Committable`, etc.
     VidDisperseRecv(VidDisperse<TYPES>, TYPES::SignatureKey),
     /// Send a VID vote to the VID leader; emitted by VID storage nodes in the DA task after seeing a valid VID dispersal
     ///

diff --git a/crates/types/src/data.rs b/crates/types/src/data.rs
@@ -160,6 +160,9 @@ pub type VidScheme = jf_primitives::vid::advz::Advz<ark_bls12_381::Bls12_381, sh
 pub use jf_primitives::vid::VidScheme as VidSchemeTrait;
 
 /// VID dispersal data
+///
+/// TODO https://github.com/EspressoSystems/HotShot/issues/1695
+/// `VidDisperse` should be of the form `Proposal<DAProposal<TYPES>>` to mirror `DAProposalRecv`. We need things like `Committable`, etc.
 #[derive(Debug, Serialize, Deserialize, Clone, Eq, PartialEq, Hash)]
 pub struct VidDisperse<TYPES: NodeType> {
     /// The view number for which this VID data is intended