Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shearing + disabled scale inheritance + flipY = true does not work as intended. #951

Closed
badlogic opened this issue Jul 19, 2017 · 3 comments
Assignees

Comments

@badlogic
Copy link
Collaborator

Repro http://esotericsoftware.com/forum/download/file.php?id=3559

The arm bone has skew on it in the default animation. That plus flipY set to true will result in this

https://libgdx.badlogicgames.com/uploads/Screen%20Shot%202017-07-19%20at%2011.33.27%20AM-Wq72j5VMXQ.png

When this is the expected output:

https://libgdx.badlogicgames.com/uploads/Screen%20Shot%202017-07-19%20at%2011.33.46%20AM-VdK0n7Y4aR.png

@badlogic
Copy link
Collaborator Author

Bone:210 is wrong, this only works if a,b,c,d form an ortho basis, which is not the case if shearing is applied.

@badlogic badlogic changed the title Shearing + flipY = true does not work as intended. Shearing + disabled scale inheritance + flipY = true does not work as intended. Jul 19, 2017
@badlogic
Copy link
Collaborator Author

If flip is set on skeleton, then root encodes flipping. However, in noScale, noScaleOrReflection case, that root flipping is smoked when we reconstruct parent local y-axes. We need to flip parent local y-axes manually in that transformation mode, as it is reconstructed from ortho normal basis, and does not encode flipping anymore.

@badlogic
Copy link
Collaborator Author

badlogic commented Jul 19, 2017

  • spine-libgdx

  • spine-csharp
  • spine-xna
  • spine-monogame
  • spine-unity
  • spine-tk2d

  • spine-c
  • spine-sfml
  • spine-cocos2d-objc
  • spine-cocos2dx
  • spine-ue4

  • spine-ts core
  • spine-ts webgl
  • spine-ts canvas
  • spine-ts threejs

  • spine-as3
  • spine-starling

  • spine-lua
  • spine-love
  • spine-corona

@NathanSweet NathanSweet removed the bug label Jul 19, 2017
@badlogic badlogic removed the bug label Jul 19, 2017
cloudchui pushed a commit to CloudcadeSF/spine-runtimes that referenced this issue Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants