Update logic to incorporate changes in ActiveModel::Dirty in Rails 5.2 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excid3
requested changes
Dec 17, 2021
|
I just ran your test against the codebase without your code changes and it passes, so it looks like we're already fine with Rails 5.2+. Did you have a test that failed against the current implementation? |
@excid3 I do not have a test which fail against the current implementation due to both methods behave similarly in this situation. These new method are more intuitive and brings more clarity while reading code. |
|
Okay, I thought your PR description was saying that it wasn't working properly with Rails 5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 5, Activemode::Dirty behaviour has changed for
_changed?,_wasin before callbacks.For reference: rails/rails#25337