Skip to content

Commit

Permalink
feat: Add support for .NET8 (dotnet#9424)
Browse files Browse the repository at this point in the history
* feat: Add support for .NET8

* chore: fix target frameworks for test assets project

* chore: update Microsoft.Build NuGet package.
  • Loading branch information
filzrev authored and p-kostov committed Jun 28, 2024
1 parent 819d55d commit dc8fbb7
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 26 deletions.
4 changes: 1 addition & 3 deletions .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ runs:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: |
6.x
7.x
8.0.100-rc.2.23502.2
8.x
- run: npm install
shell: bash
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ jobs:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: |
6.x
7.x
8.0.100-rc.2.23502.2
8.x
- uses: github/codeql-action/init@v2
with:
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: |
6.x
7.x
8.0.100-rc.2.23502.2
8.x
- run: npm install
working-directory: templates
Expand Down Expand Up @@ -60,14 +58,14 @@ jobs:
steps:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.x
dotnet-version: 8.x

- uses: actions/download-artifact@v3
with:
name: nuget
path: drop/nuget

- run: dotnet tool install --tool-path . sign --version 0.9.1-beta.23356.1
- run: dotnet tool install --tool-path . sign --version 0.9.1-beta.23530.1

- run: >
./sign code azure-key-vault
Expand All @@ -94,7 +92,7 @@ jobs:
steps:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.x
dotnet-version: 8.x

- uses: actions/download-artifact@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(TargetFrameworks);net8.0</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<!--<TargetFrameworks Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(TargetFrameworks);net9.0</TargetFrameworks>-->
<LangVersion>Preview</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
Expand Down
19 changes: 10 additions & 9 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@
<PackageVersion Include="Markdig" Version="0.33.0" />
<!-- "17.3.2" is the latest compatible version for .NET 6 -->
<PackageVersion Include="Microsoft.Build" Version="[17.3.2]" Condition="'$(TargetFramework)' == 'net6.0'" />
<PackageVersion Include="Microsoft.Build" Version="17.7.2" Condition="'$(TargetFramework)' != 'net6.0'" />
<PackageVersion Include="Microsoft.Build" Version="[17.7.2]" Condition="'$(TargetFramework)' == 'net7.0'" />
<PackageVersion Include="Microsoft.Build" Version="17.8.3" Condition="'$(TargetFramework)' != 'net6.0' And '$(TargetFramework)' != 'net7.0'" />
<PackageVersion Include="Microsoft.Build.Locator" Version="1.6.10" />
<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.7.0" />
<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.8.0-3.final" />
<PackageVersion Include="Microsoft.Playwright" Version="1.37.1" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
Expand Down
2 changes: 1 addition & 1 deletion test/docfx.Tests/Assets/ref.csproj.sample.1
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>net6.0</TargetFrameworks>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion test/docfx.Tests/Assets/test.csproj.sample.1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>net6.0</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion test/docfx.Tests/Assets/test.vbproj.sample.1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>net6.0</TargetFrameworks>
<RootNamespace>testVBproj1</RootNamespace>
<AssemblyName>test.sample.1</AssemblyName>
<OptionExplicit>On</OptionExplicit>
Expand Down

0 comments on commit dc8fbb7

Please sign in to comment.