feat: change some internal types from public to internal (dotnet#9401)

Co-authored-by: Yufei Huang <[email protected]>
ErpNetDocs · Jun 28, 2024 · 50354b3 · 50354b3
1 parent 9765e96
commit 50354b3
Show file tree

Hide file tree

Showing 33 changed files with 28 additions and 298 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -33,7 +33,6 @@
     <PackageVersion Include="Stubble.Core" Version="1.10.8" />
     <PackageVersion Include="System.Collections.Immutable" Version="7.0.0" />
     <PackageVersion Include="System.Composition" Version="7.0.0" />
-    <PackageVersion Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
     <PackageVersion Include="YamlDotNet" Version="13.7.1" />
     <!-- Test only -->
     <PackageVersion Include="coverlet.collector" Version="6.0.0" />

diff --git a/src/Docfx.Build/CompositionContainer.cs b/src/Docfx.Build/CompositionContainer.cs
@@ -10,7 +10,7 @@
 namespace Docfx.Common;
 
 [Export(typeof(ICompositionContainer))]
-public class CompositionContainer : ICompositionContainer
+class CompositionContainer : ICompositionContainer
 {
     public static CompositionHost DefaultContainer { get; private set; }
 

diff --git a/src/Docfx.Build/Conceptual/BuildConceptualDocument.cs b/src/Docfx.Build/Conceptual/BuildConceptualDocument.cs
@@ -12,7 +12,7 @@
 namespace Docfx.Build.ConceptualDocuments;
 
 [Export(nameof(ConceptualDocumentProcessor), typeof(IDocumentBuildStep))]
-public class BuildConceptualDocument : BaseDocumentBuildStep
+class BuildConceptualDocument : BaseDocumentBuildStep
 {
     private const string ConceptualKey = Constants.PropertyName.Conceptual;
     private const string DocumentTypeKey = "documentType";

diff --git a/src/Docfx.Build/Conceptual/ConceptualDocumentProcessor.cs b/src/Docfx.Build/Conceptual/ConceptualDocumentProcessor.cs
@@ -12,7 +12,7 @@
 namespace Docfx.Build.ConceptualDocuments;
 
 [Export(typeof(IDocumentProcessor))]
-public class ConceptualDocumentProcessor : DisposableDocumentProcessor
+class ConceptualDocumentProcessor : DisposableDocumentProcessor
 {
     #region Fields
 

diff --git a/src/Docfx.Build/Conceptual/CountWord.cs b/src/Docfx.Build/Conceptual/CountWord.cs
@@ -11,7 +11,7 @@
 namespace Docfx.Build.ConceptualDocuments;
 
 [Export(nameof(ConceptualDocumentProcessor), typeof(IDocumentBuildStep))]
-public class CountWord : BaseDocumentBuildStep
+class CountWord : BaseDocumentBuildStep
 {
     public override string Name => nameof(CountWord);
 

diff --git a/src/Docfx.Build/Conceptual/HtmlDocumentUtility.cs b/src/Docfx.Build/Conceptual/HtmlDocumentUtility.cs
@@ -6,7 +6,7 @@
 
 namespace Docfx.Build.ConceptualDocuments;
 
-public static class HtmlDocumentUtility
+static class HtmlDocumentUtility
 {
     public static SeparatedHtmlInfo SeparateHtml(string contentHtml)
     {

diff --git a/src/Docfx.Build/Conceptual/SeparatedHtmlInfo.cs b/src/Docfx.Build/Conceptual/SeparatedHtmlInfo.cs
@@ -3,7 +3,7 @@
 
 namespace Docfx.Build.ConceptualDocuments;
 
-public class SeparatedHtmlInfo
+class SeparatedHtmlInfo
 {
     public string Title { get; set; }
 

diff --git a/src/Docfx.Build/Conceptual/ValidateConceptualDocumentMetadata.cs b/src/Docfx.Build/Conceptual/ValidateConceptualDocumentMetadata.cs
@@ -11,7 +11,7 @@
 namespace Docfx.Build.ConceptualDocuments;
 
 [Export(nameof(ConceptualDocumentProcessor), typeof(IDocumentBuildStep))]
-public class ValidateConceptualDocumentMetadata : BaseDocumentBuildStep
+class ValidateConceptualDocumentMetadata : BaseDocumentBuildStep
 {
     private const string ConceptualKey = Constants.PropertyName.Conceptual;
 

diff --git a/src/Docfx.Build/FileMetadataConverter.cs b/src/Docfx.Build/FileMetadataConverter.cs
diff --git a/src/Docfx.Build/ManifestUtility.cs b/src/Docfx.Build/ManifestUtility.cs
@@ -10,7 +10,7 @@ namespace Docfx.Common;
 
 #pragma warning disable CS0612 // Type or member is obsolete
 
-public static class ManifestUtility
+static class ManifestUtility
 {
     public static void RemoveDuplicateOutputFiles(ManifestItemCollection manifestItems)
     {

diff --git a/src/Docfx.Build/PostProcessors/ExtractSearchIndex.cs b/src/Docfx.Build/PostProcessors/ExtractSearchIndex.cs
@@ -14,7 +14,7 @@
 namespace Docfx.Build.Engine;
 
 [Export(nameof(ExtractSearchIndex), typeof(IPostProcessor))]
-public class ExtractSearchIndex : IPostProcessor
+class ExtractSearchIndex : IPostProcessor
 {
     private static readonly Regex s_regexWhiteSpace = new(@"\s+", RegexOptions.Compiled);
     private static readonly HashSet<string> s_htmlInlineTags = new(StringComparer.OrdinalIgnoreCase)

diff --git a/src/Docfx.Build/PostProcessors/HtmlPostProcessor.cs b/src/Docfx.Build/PostProcessors/HtmlPostProcessor.cs
@@ -11,7 +11,7 @@
 
 namespace Docfx.Build.Engine;
 
-internal sealed class HtmlPostProcessor : IPostProcessor
+sealed class HtmlPostProcessor : IPostProcessor
 {
     public List<IHtmlDocumentHandler> Handlers { get; } = new List<IHtmlDocumentHandler>();
 

diff --git a/src/Docfx.Build/PostProcessors/PostProcessor.cs b/src/Docfx.Build/PostProcessors/PostProcessor.cs
@@ -5,7 +5,7 @@
 
 namespace Docfx.Build.Engine;
 
-internal sealed class PostProcessor
+sealed class PostProcessor
 {
     public string ContractName { get; set; }
 

diff --git a/src/Docfx.Build/PostProcessors/PostProcessorsManager.cs b/src/Docfx.Build/PostProcessors/PostProcessorsManager.cs
@@ -10,7 +10,7 @@
 
 namespace Docfx.Build.Engine;
 
-internal class PostProcessorsManager : IDisposable
+class PostProcessorsManager : IDisposable
 {
     private readonly List<PostProcessor> _postProcessors;
 

diff --git a/src/Docfx.Build/PostProcessors/RemoveDebugInfo.cs b/src/Docfx.Build/PostProcessors/RemoveDebugInfo.cs
@@ -6,7 +6,7 @@
 
 namespace Docfx.Build.Engine;
 
-public sealed class RemoveDebugInfo : HtmlDocumentHandler
+class RemoveDebugInfo : HtmlDocumentHandler
 {
     private readonly string[] DebugInfoAttributes =
     {

diff --git a/src/Docfx.Build/PostProcessors/SearchIndexItem.cs b/src/Docfx.Build/PostProcessors/SearchIndexItem.cs
@@ -6,7 +6,7 @@
 
 namespace Docfx.Build.Engine;
 
-public class SearchIndexItem
+class SearchIndexItem
 {
     [JsonProperty("href")]
     [JsonPropertyName("href")]

diff --git a/src/Docfx.Build/PostProcessors/SitemapGenerator.cs b/src/Docfx.Build/PostProcessors/SitemapGenerator.cs
@@ -13,7 +13,7 @@
 namespace Docfx.Build.Engine;
 
 [Export(nameof(SitemapGenerator), typeof(IPostProcessor))]
-public class SitemapGenerator : IPostProcessor
+class SitemapGenerator : IPostProcessor
 {
     private static readonly XNamespace Namespace = "http://www.sitemaps.org/schemas/sitemap/0.9"; // lgtm [cs/non-https-url]
     private const string HtmlExtension = ".html";

diff --git a/src/Docfx.Build/PostProcessors/ValidateBookmark.cs b/src/Docfx.Build/PostProcessors/ValidateBookmark.cs
@@ -9,7 +9,7 @@
 
 namespace Docfx.Build.Engine;
 
-public sealed class ValidateBookmark : HtmlDocumentHandler
+sealed class ValidateBookmark : HtmlDocumentHandler
 {
     private static readonly string XPathTemplate = "//*/@{0}";
     private static readonly HashSet<string> WhiteList = new() { "top" };

diff --git a/src/Docfx.Build/ResourceFiles/ResourceDocumentProcessor.cs b/src/Docfx.Build/ResourceFiles/ResourceDocumentProcessor.cs
@@ -10,7 +10,7 @@
 namespace Docfx.Build.ResourceFiles;
 
 [Export(typeof(IDocumentProcessor))]
-public class ResourceDocumentProcessor : DisposableDocumentProcessor
+class ResourceDocumentProcessor : DisposableDocumentProcessor
 {
     [ImportMany]
     public IEnumerable<IResourceFileConfig> Configs { get; set; }

diff --git a/src/Docfx.Build/ResourceFiles/ValidateResourceMetadata.cs b/src/Docfx.Build/ResourceFiles/ValidateResourceMetadata.cs
@@ -9,7 +9,7 @@
 namespace Docfx.Build.ResourceFiles;
 
 [Export(nameof(ResourceDocumentProcessor), typeof(IDocumentBuildStep))]
-public class ValidateResourceMetadata : BaseDocumentBuildStep
+class ValidateResourceMetadata : BaseDocumentBuildStep
 {
     public override string Name => nameof(ValidateResourceMetadata);
 

diff --git a/src/Docfx.Build/TableOfContents/BuildTocDocument.cs b/src/Docfx.Build/TableOfContents/BuildTocDocument.cs
@@ -13,7 +13,7 @@
 namespace Docfx.Build.TableOfContents;
 
 [Export(nameof(TocDocumentProcessor), typeof(IDocumentBuildStep))]
-public class BuildTocDocument : BaseDocumentBuildStep
+class BuildTocDocument : BaseDocumentBuildStep
 {
     public override string Name => nameof(BuildTocDocument);
 

diff --git a/src/Docfx.Build/TableOfContents/HrefType.cs b/src/Docfx.Build/TableOfContents/HrefType.cs
@@ -3,7 +3,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal enum HrefType
+enum HrefType
 {
     AbsolutePath,
     RelativeFile,

diff --git a/src/Docfx.Build/TableOfContents/TocDocumentProcessor.cs b/src/Docfx.Build/TableOfContents/TocDocumentProcessor.cs
@@ -12,7 +12,7 @@
 namespace Docfx.Build.TableOfContents;
 
 [Export(typeof(IDocumentProcessor))]
-public class TocDocumentProcessor : DisposableDocumentProcessor
+class TocDocumentProcessor : DisposableDocumentProcessor
 {
     private static readonly char[] QueryStringOrAnchor = new[] { '#', '?' };
 

diff --git a/src/Docfx.Build/TableOfContents/TocFileType.cs b/src/Docfx.Build/TableOfContents/TocFileType.cs
@@ -3,7 +3,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal enum TocFileType
+enum TocFileType
 {
     None,
     Markdown,

diff --git a/src/Docfx.Build/TableOfContents/TocHelper.cs b/src/Docfx.Build/TableOfContents/TocHelper.cs
@@ -9,7 +9,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-public static class TocHelper
+static class TocHelper
 {
     private static readonly YamlDeserializerWithFallback _deserializer =
         YamlDeserializerWithFallback.Create<TocViewModel>()

diff --git a/src/Docfx.Build/TableOfContents/TocItemInfo.cs b/src/Docfx.Build/TableOfContents/TocItemInfo.cs
@@ -6,7 +6,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal sealed class TocItemInfo
+class TocItemInfo
 {
     public TocItemViewModel Content { get; set; }
     public FileAndType File { get; }

diff --git a/src/Docfx.Build/TableOfContents/TocResolver.cs b/src/Docfx.Build/TableOfContents/TocResolver.cs
@@ -7,7 +7,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal sealed class TocResolver
+class TocResolver
 {
     private readonly Dictionary<string, TocItemInfo> _collection;
     private readonly Dictionary<FileAndType, TocItemInfo> _notInProjectTocCache = new();

diff --git a/src/Docfx.Build/TableOfContents/TocRestructureUtility.cs b/src/Docfx.Build/TableOfContents/TocRestructureUtility.cs
@@ -7,7 +7,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal static class TocRestructureUtility
+static class TocRestructureUtility
 {
     public static void Restructure(TocItemViewModel toc, IList<TreeItemRestructure> restructures)
     {

diff --git a/src/Docfx.Build/TableOfContents/Utility.cs b/src/Docfx.Build/TableOfContents/Utility.cs
@@ -6,7 +6,7 @@
 
 namespace Docfx.Build.TableOfContents;
 
-internal static class Utility
+static class Utility
 {
     public static bool IsSupportedFile(string file)
     {

diff --git a/src/Docfx.Dotnet/Docfx.Dotnet.csproj b/src/Docfx.Dotnet/Docfx.Dotnet.csproj
@@ -33,7 +33,6 @@
     <PackageReference Include="IgnoresAccessChecksToGenerator" PrivateAssets="All" />
     <PackageReference Include="OneOf" />
     <PackageReference Include="OneOf.SourceGenerator" />
-    <PackageReference Include="System.Configuration.ConfigurationManager" />
     <PackageReference Include="Markdig" />
     <PackageReference Include="Microsoft.Build" ExcludeAssets="runtime" />
     <PackageReference Include="Microsoft.Build.Locator" />