change based on pr feedback

Erin-Mounts · Feb 27, 2016 · db64847 · db64847
1 parent c9df50f
commit db64847
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/APCAppCore/APCAppCore/DataSubstrate/Model/APCSmartSurveyTask.m b/APCAppCore/APCAppCore/DataSubstrate/Model/APCSmartSurveyTask.m
@@ -574,16 +574,14 @@ - (ORKAnswerFormat*) rkChoiceAnswerFormat:(NSDictionary *)objectDictionary
     }];
     if (localConstraints.allowOtherValue)
     {
+        NSString* otherStr = NSLocalizedStringWithDefaultValue(@"Other", @"APCAppCore", APCBundle(), @"Other", @"Spinner Option");
         // Smart capitalization will lowercase the "Other" option if all the other answers are lowercase
         if (sAPCSmartSurveyEnableOtherAutoCapitalization &&
             [self allLowercaseOptions:localConstraints])
         {
-            [options addObject:NSLocalizedStringWithDefaultValue(@"other", @"APCAppCore", APCBundle(), @"other", @"Spinner Option")];
-        }
-        else
-        {
-            [options addObject:NSLocalizedStringWithDefaultValue(@"Other", @"APCAppCore", APCBundle(), @"Other", @"Spinner Option")];
+            otherStr = [otherStr lowercaseString];
         }
+        [options addObject:otherStr];
     }
     retAnswer = [ORKAnswerFormat choiceAnswerFormatWithStyle:localConstraints.allowMultipleValue ? ORKChoiceAnswerStyleMultipleChoice : ORKChoiceAnswerStyleSingleChoice textChoices:options];
     return retAnswer;