Allows Variable Notification Window Height #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAX_HEIGHT is now dependent on the variable ConfigModel.instance.notification_window_height
Introduce variable notification_window_height
|
The issue with this is that the layer could extend past the outputs bounds if the height is very large, hiding notifications. That's why I haven't really looked into this... One solution would be to always have it set to the outputs height while only allowing input inside the used area (setting the surfaces input region). Not sure if this is possible in GTK though |
|
I mean, the same is true for I think both should be available to the user with comments next to them to warn of their misuse. screenrecord.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Variable Notification Window Height
Solves:
@/issues/174
@/issues/274
@/issues/177