Add JSONObject.GetType() and JSONArray.GetType() methods #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wend4r
changed the title
|
@CrazyHackGUT @ErikMinekus Can you guys merge it ? |
|
I don't have permissions for merge in this repo. |
|
I don't have any plans to merge this at the moment. In my opinion, checking the type of a value to see which Get* function you need to call is not a good solution. You should already know the structure and types beforehand. The only issue I see is that JavaScript encodes whole float numbers as integers, which I would like to solve in a different way. |
|
I have a real use case for it right here if you want to know why we need this https://gitlab.com/counterstrikesource/sm-plugins/smjsonapi/-/blob/master/addons/sourcemod/scripting/SMJSONAPI.sp#L236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.