CloneDbConnection handles AccessTokenCallback #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
requested changes
May 22, 2024
src/ErikEJ.EntityFramework.SqlServer/MicrosoftSqlProviderServices.cs
Outdated
Show resolved
Hide resolved
src/ErikEJ.EntityFramework.SqlServer/ErikEJ.EntityFramework.SqlServer.csproj
Show resolved
Hide resolved
|
I like this the best! Simple and value adding |
|
Maybe add a little something to the readme as well? |
ErikEJ
approved these changes
May 22, 2024
|
Thank you, Erik! |
|
@rayao Thanks for a great contribution, I have just published to NuGet |
|
@rayao Have you been able to verify that the updated package works as expected? |
|
@ErikEJ Our CI system needs some time to push a change to deployment, I'll report later today. |
|
It's just been proved that the updated package works as expected, we're unblocked. |
|
Fantastic, thanks for confirming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when cloning, properly copy AccessTokenCallback