Round 2 of fixes #34
Closed
Round 2 of fixes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• whitespace cleanup / harmonisation • const • some ordering without side effects • comments • correct type *_MAX constant
(cherry picked from commit 34ecd11)
still works: 58.1 Transmit rate = 202059kbps, PLR = 0.00%( 0.00%), RTT = 0.000s, Queue delay = 0.000s
IngJohEricsson
approved these changes
Jul 2, 2020
some contributors use git implementations that utterly hose symlinks
|
@IngJohEricsson I’ve rebased my changes you already approved on today’s latest |
|
superceded by #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @IngJohEricsson,
this is round 2 of my fixes. I verified I can reach 200+ kbps with this (now that I know it’s bit, not bytes), and I did not symlink the files again.
const, comments,UINT32_MAX, etc. againRtpQueue.cppfiles in the repository)README.mdwhich I already prepared