Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release CI workflow with a version check and prepare for release 0.7.1 #74

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Nov 20, 2024

  • Add a CI workflow that is only run when a tag is pushed to
    Github, and a check that the ered application vsn is matching
    the pushed tag.
    application:get_key(ered, vsn) is used to get the vsn version
    and the shell will return an error code when the version and
    the tag is not matching, which fails the CI job.

  • The 0.7.0 release provided the faulty application vsn string 0.6.0.
    Update vsn to 0.7.1 to prepare for a new release.

Add a CI workflow that is only run when a tag is pushed to
Github, and a check that the ered application vsn is matching
the pushed tag.

application:get_key(ered, vsn) is used to get the vsn version
and the shell will return an error code when the version and
the tag is not matching, which fails the CI job.
The 0.7.0 release provided the faulty application vsn string 0.6.0.
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! How do you test that this CI job works? Did you try to push a dummy tag in another fork?

@bjosv
Copy link
Collaborator Author

bjosv commented Nov 22, 2024

How do you test that this CI job works?

I tested it in a temporary repo to get it right. It for sure took some iterations to get Githubs shell and rebar3 to do what I wanted :)

@bjosv bjosv merged commit 34863c7 into Ericsson:main Nov 22, 2024
10 checks passed
@bjosv bjosv deleted the check-version branch November 22, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants