-
Notifications
You must be signed in to change notification settings - Fork 26
Fix blacklist #165
base: master
Are you sure you want to change the base?
Fix blacklist #165
Conversation
CraftTweaker blacklist fixed in the most recent commit. |
NOTE: Doesn't work until enchanting plus is updated with my pr here: Epoxide-Software/Enchanting-Plus#165
@Darkhax pls review |
It would be great if this could get merged in, helps out a lot with modpacks (specifically Rebirth of the Night) |
@democat3457 It seems that with your commit tools & armor that have been used (with durability) can still be enchanted. |
This is good, no? |
This means it's still impossible to prevent Tinkers gear from being used in the Advanced Enchanting Table. |
oh i see - the blacklist currently doesn't apply to items with different durabilities. Do you know if Tinkers uses durabilities via NBT, metadata, or actual durability values? |
Hmm, I don't but the mod is open source - https://github.com/SlimeKnights/TinkersConstruct/tree/1.12 |
@xJon have you tried putting a wildcard meta at the end of the item in the config? or try using crafttweaker with an itemstack that has a * meta. in any case, the most recent commit should also fix that by defaulting items without meta in the config to a wildcard meta |
This should fix #161 by not checking for similar NBT tags. This allows modded installs to function properly (since you can't specify NBT in the configuration file). CraftTweaker blacklist is still broken though.