Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Fix blacklist #165

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

democat3457
Copy link

@democat3457 democat3457 commented Apr 27, 2020

This should fix #161 by not checking for similar NBT tags. This allows modded installs to function properly (since you can't specify NBT in the configuration file). CraftTweaker blacklist is still broken though.

@democat3457
Copy link
Author

CraftTweaker blacklist fixed in the most recent commit.

democat3457 added a commit to democat3457/Rebirth-Of-The-Night that referenced this pull request May 6, 2020
NOTE: Doesn't work until enchanting plus is updated with my pr here: Epoxide-Software/Enchanting-Plus#165
@democat3457
Copy link
Author

@Darkhax pls review

@kil0byt3
Copy link

kil0byt3 commented May 6, 2020

It would be great if this could get merged in, helps out a lot with modpacks (specifically Rebirth of the Night)

@xJon
Copy link

xJon commented Nov 6, 2021

@democat3457 It seems that with your commit tools & armor that have been used (with durability) can still be enchanted.

@democat3457
Copy link
Author

This is good, no?

@xJon
Copy link

xJon commented Nov 8, 2021

This is good, no?

This means it's still impossible to prevent Tinkers gear from being used in the Advanced Enchanting Table.
It'd be preferable to be able to prevent Tinkers gear from being enchanted regardless of durability :)

@democat3457
Copy link
Author

oh i see - the blacklist currently doesn't apply to items with different durabilities. Do you know if Tinkers uses durabilities via NBT, metadata, or actual durability values?

@xJon
Copy link

xJon commented Nov 10, 2021

Hmm, I don't but the mod is open source - https://github.com/SlimeKnights/TinkersConstruct/tree/1.12
Also that is the case for non tinkers items too, the blacklist only works if they haven't been used.

@democat3457
Copy link
Author

@xJon have you tried putting a wildcard meta at the end of the item in the config? or try using crafttweaker with an itemstack that has a * meta.

in any case, the most recent commit should also fix that by defaulting items without meta in the config to a wildcard meta

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item blacklist not working
3 participants