request headers #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,16 @@ def index | |||
| end | |||
|
|
|||
| def create | |||
| @subscriber = Subscriber.where("email = ? and website_id = ?", params['email'], @current_site.id) | |||
| @error = Issue.where("description = ?", params['message']) | |||
There was a problem hiding this comment.
asta nu prea are sens. description ala cel mai probabil o sa fie un backtrace sau un mesaj pe care il trimite siteu cu eroarea. Ti-am zis ca params['message'] asta nu prea are loc in momentul asta. Ce putem sa facem e sa adaugam un nou tabel cu mesajele. Si sa fie mesajele legate de issue_id si subscriber_id
| app_id = request.headers['HTTP_APP_ID'] | ||
| @current_site ||= Website.find_by_app_id_and_app_key(app_id, app_key) | ||
| end | ||
|
|
||
| def current_site | ||
| if params[:website_id] && current_member | ||
| @current_site ||= current_member.websites.where("websites.id = ?", params[:website_id]).try(:first) |
There was a problem hiding this comment.
hai sa facem aici altfel. Hai sa combinam in metoda asta current_site cu metoda aia set_websites_from_header. Fai aici asa:
if params[:website_id] && current_member
@current_site ||= current_member.websites.where("websites.id = ?", params[:website_id]).try(:first)
else
@current_site ||= Website.find_by_app_id_and_app_key(request.headers['HTTP_APP_ID'], request.headers['HTTP_APP_KEY'])
end
In felu asta nu avem nevoie de before_filter deasupra si nici de metoda aia de am facut-o acum
| subscriber = current_site.subscribers.find_by(email: params[:email]) | ||
| error = current_site.issues.find_by(page_title: params[:page_title]) | ||
| if subscriber | ||
| subscriber = current_site.subscribers.create( email: params['email'], name: params['email'], website_id: current_site.id) |
- also incremented occurences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.