send_mail_to_users #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <%= JsRoutes.generate(default_url_options: { :host => 'localhost:3000' }, url_links: true, exclude: [/admin/] ) %> |
There was a problem hiding this comment.
asta nu a mers sa lasi cu ENV?? De ce ai pus fix localhost:3000 ??
There was a problem hiding this comment.
te rog sa pui la loc ENV['APP_DOMAIN'] aici si o sa fac merge.
| $('form#notify').submit -> | ||
| dataString = $('.messageTextarea').val() | ||
| theid = $(this).attr('data-the_id') |
| @error = Issue.find(params[:id]) | ||
| @message = params[:message] | ||
| Website.find(@error.website_id).subscribers.each do |member| | ||
| UserMailer.issue_solved(@error, member, @message).deliver_now |
There was a problem hiding this comment.
Hai sa schimbam si numele asta sa ii zicem notify_subscriber si fai un IssueMailer si sa lasam UserMailer pt altceva.
There was a problem hiding this comment.
Deci fai IssueMailer.notify_subscriber
| describe 'GET #show' do | ||
| it 'should assign error' do | ||
| auth_member(member) | ||
| get :show, { id: issue_error.id, error: {status: issue_error.status }, website_id: website.id, format: :json } |
There was a problem hiding this comment.
aici nu ai nevoie de error: {status: issue_error.status} pt ca nu faci update doar vrei sa iei issue. la fel si la testu de jos
| %p An issue has just been solved. | ||
| %p Website title: #{@website.title} | ||
| %p #{@message} | ||
| %p Thanks for joining and have a great day! |
There was a problem hiding this comment.
Schimba mailu asta sa fie asa:
Hi, #{@member.name},
%p #{@message}
%p This email was sent because you subscribed to an error on our website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.