-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to the error pages #203
Conversation
945fec9
to
4479e95
Compare
Current coverage is 97.03% (diff: 100%)@@ master #203 diff @@
==========================================
Files 172 172
Lines 5553 5559 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5388 5394 +6
Misses 165 165
Partials 0 0
|
Reviewed 3 of 4 files at r1. app/views/errors/index.html.haml, line 23 [r1] (raw file):
Why are you doing this here? You can just have that subscribers call in the partial. Also, that line of code is really weird. Comments from Reviewable |
ed2f8d0
to
91d7184
Compare
- if subscribers.size > 0 | ||
%h5.pull-right | ||
This message will be sent to | ||
= subscribers.size.to_s + (subscribers.size > 1 ? ' users' : ' user') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use i18n for this. Look at rails i18n count. You should have this line here: = t('subscribers.count', count: subscribers.size)
Reviewed 4 of 7 files at r3. Comments from Reviewable |
Reviewed 1 of 2 files at r2, 3 of 7 files at r3, 2 of 2 files at r4. Comments from Reviewable |
…er page has been changed
98a853b
to
1fb1450
Compare
Fixes #186, #194, #195, #217, #222
This change is