Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat integrations #102

Merged
merged 24 commits into from
Jul 13, 2016
Merged

Feat integrations #102

merged 24 commits into from
Jul 13, 2016

Conversation

Chocksy
Copy link
Member

@Chocksy Chocksy commented Mar 4, 2016

fixes #24

  • create method in drivers to hold the api_url of each. Please use a config in integrations.yml that defines if the integration is in sandbox mode or not:
def api_url
   if config[:sandbox]
     'http..sandbox'
  else
    'http..live'
  end
end
  • make the method that calls to get repositories from github and we'll need a method in integrations that will call that method as a general one to make sure we can use this for other instances.
  • make a method in intercom that gets the same websites from their api
  • write specs for auth_controller and the integrations lib files
  • make the intercom not use the select_application functionality it does not need it
  • adjust the github select repo code to include the organization repos too
  • change the view for adding integrations to a simple table instead of tabs

@Chocksy Chocksy self-assigned this Mar 4, 2016
@Chocksy Chocksy added this to the version 1.0 milestone Mar 4, 2016
@Chocksy Chocksy force-pushed the feat-integrations branch from 4495d85 to 6fa1e40 Compare March 24, 2016 13:35
@Chocksy Chocksy force-pushed the feat-integrations branch 6 times, most recently from bb327ec to c9898f9 Compare April 18, 2016 09:06
@Chocksy Chocksy force-pushed the feat-integrations branch 4 times, most recently from ca14de6 to a283f0b Compare April 20, 2016 16:16
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 April 20, 2016 16:16 Inactive
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 April 20, 2016 16:16 Inactive
@Chocksy Chocksy force-pushed the master branch 2 times, most recently from f30654e to 09beb6d Compare May 12, 2016 12:45
@Chocksy Chocksy force-pushed the feat-integrations branch from a283f0b to 89c4b3a Compare May 12, 2016 16:34
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 12, 2016 16:34 Inactive
@codecov-io
Copy link

codecov-io commented May 12, 2016

Current coverage is 97.14%

Merging #102 into master will increase coverage by 0.60%

@@             master       #102   diff @@
==========================================
  Files           172        173     +1   
  Lines          4864       5436   +572   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           4696       5281   +585   
+ Misses          168        155    -13   
  Partials          0          0          

Powered by Codecov. Last updated by 7b6e32f...40bebc4

@Chocksy Chocksy force-pushed the feat-integrations branch from 89c4b3a to 7535736 Compare May 20, 2016 10:16
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 20, 2016 10:16 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from 7535736 to 04420eb Compare May 20, 2016 10:30
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 20, 2016 10:30 Inactive
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 20, 2016 10:33 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from 04420eb to 0cdab4b Compare May 24, 2016 11:47
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 24, 2016 11:47 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from 0cdab4b to d928b4a Compare May 25, 2016 10:38
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 May 25, 2016 10:38 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from f4bb2ed to 2821847 Compare July 13, 2016 08:02
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 July 13, 2016 08:02 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from 2821847 to cc72e55 Compare July 13, 2016 08:22
@Chocksy Chocksy temporarily deployed to epiclogger-staging-pr-102 July 13, 2016 08:22 Inactive
@Chocksy Chocksy force-pushed the feat-integrations branch from cc72e55 to 40bebc4 Compare July 13, 2016 09:35
@Chocksy Chocksy merged commit 40bebc4 into master Jul 13, 2016
@Chocksy Chocksy deleted the feat-integrations branch July 13, 2016 09:41
@Chocksy Chocksy temporarily deployed to epiclogger-staging July 13, 2016 09:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement integration with intercom
3 participants