fixed a bug where context_locals could be nil + spec

EpicCoders · May 11, 2016 · 15c1516 · 15c1516
1 parent d4a8088
commit 15c1516
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/error_store/interfaces/frame.rb b/lib/error_store/interfaces/frame.rb
@@ -45,11 +45,11 @@ def sanitize_data(data)
       function = nil if function == '?'
 
       context_locals = data[:vars]
-      context_locals = if context_locals.is_a?(Array)
-                         Hash[context_locals]
-                       elsif !context_locals.is_a?(Hash)
-                         {}
-                       end
+      if context_locals.is_a?(Array)
+        context_locals = Hash[context_locals]
+      elsif !context_locals.is_a?(Hash)
+        context_locals = {}
+      end
 
       context_locals = trim_hash(context_locals) do |result|
         handle_nan(result)

diff --git a/spec/lib/error_store/interfaces/frame_spec.rb b/spec/lib/error_store/interfaces/frame_spec.rb
@@ -67,6 +67,11 @@
       expect( subject._data[:vars] ).to eq({})
     end
 
+    it 'does not change the value of context_locals if its already a Hash' do
+      post_data[:vars] = { value: 'zoro' }
+      expect( subject._data[:vars] ).to eq( { value: 'zoro' } )
+    end
+
     it 'trimps hash of context_locals' do
       post_data[:vars] = generate_array(100)
       expect( subject._data[:vars].length ).to eq(ErrorStore::MAX_HASH_ITEMS)