JOSS review: No github CI badge, windows, ubuntu builds?

[kanishkan91]

Can the author add the Github CI badge to the repo? It seems the workflow has been set up. But there is no badge on the repo. Should be simple to add this in.

Also, where is the build info for a windows or ubuntu build? Has that been set up?

This would ensure long term stable development of this package.

openjournals/joss-reviews#5434

[maximelenormand]

I added a GitHub Actions badge to the repo. This is a R-CMD-check performed an the latest version of windows, mac and ubuntu. What do you mean by "build info for a windows or ubuntu build"?

[kanishkan91]

@maximelenormand I think the issue is that you've only set up the CMD checks which is more of a documentation check. You would also need a windows and ubuntu build so that GitHub would build in that environment and make sure the code compiles. Its just adding a couple more yml files like this- https://github.com/JGCRI/ambrosia/tree/master/.github/workflows

Then you can also add badges for the windows and linux builds.

[maximelenormand]

@kanishkan91 I am not sure to see the difference between https://github.com/EpiVec/TDLM/blob/master/.github/workflows/R-CMD-check.yaml and https://github.com/JGCRI/ambrosia/blob/master/.github/workflows/build_linux.yml. I am running rcmdcheck on 5 configurations (mac, windows,ubuntu devel, ubuntu release and ubuntu oldrel) each time I modify the repo. So the check is passing only if the 5 rcmdcheck are passing.

[kanishkan91]

Thanks @maximelenormand. I think this is sufficient for now. Going to close.