Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Issues in vignette #11

Closed
kanishkan91 opened this issue Jun 5, 2023 · 3 comments
Closed

JOSS review: Issues in vignette #11

kanishkan91 opened this issue Jun 5, 2023 · 3 comments

Comments

@kanishkan91
Copy link

kanishkan91 commented Jun 5, 2023

Following are the issues identified in the vignette-

  1. When using extract_opportunities I get the following error

image

  1. When I plot "county" using plot (county), I get the following plot, not the one shown in the vignette. Is that a different plotting function?

image

openjournals/joss-reviews#5434

@maximelenormand
Copy link
Member

  1. It seems that you are using an old version of write_delim in which the "progress" argument is not available. To prevent this I added a minimal version requirement for readr in the DESCRIPTION.

  2. The plot methods for sf should be used here. sf should be loaded to obtain the wanted plot, I added the following line ("library(sf)") at the beginning of the R code chunk. Thanks for pointing that out.

@maximelenormand
Copy link
Member

I added a minimal version requirement for every dependency in DESCRIPTION.

@kanishkan91
Copy link
Author

Thanks. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants