Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic model calibration #31

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Enable basic model calibration #31

merged 15 commits into from
Nov 25, 2024

Conversation

apulsipher
Copy link
Collaborator

@apulsipher apulsipher commented Nov 6, 2024

Enables basic calibration of model based on accessed data

@apulsipher apulsipher linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Is this the latest version? I have a handful of observations. LMK if you have any questions.

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
index.qmd Outdated Show resolved Hide resolved
index.qmd Outdated Show resolved Hide resolved
@apulsipher
Copy link
Collaborator Author

apulsipher commented Nov 21, 2024

Nice work! Is this the latest version? I have a handful of observations. LMK if you have any questions.

This wasn't the latest version, I've now committed the latest, but you suggestion for the Dockerfile fixed the issue I was having with epiworldR features. So thank you! Unfortunately, new changes to epiworldR broke something else in the forecast code that I'm working on debugging now

@apulsipher apulsipher requested a review from gvegayon November 21, 2024 17:48
@apulsipher
Copy link
Collaborator Author

apulsipher commented Nov 21, 2024

@gvegayon Technically, the forecast is running end to end, but the output isn't making sense.

  • I'm seeing unusually high recovery and transmission rates (rates > 1.0)
  • I'm seeing a "time to peak" that is more than 90 days (shouldn't be possible)

Can you take a look and see what I'm missing?

* Updating with fixes to epiworld

* Update epiworldR commit tag in Dockerfile

---------

Co-authored-by: Andrew Pulsipher <[email protected]>
@apulsipher apulsipher merged commit 780ac06 into main Nov 25, 2024
4 checks passed
@apulsipher apulsipher deleted the 5-basic-calibration branch November 25, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write basic model calibration script
2 participants