fixing infinity loop bug in date range #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. Thanks for this. Someone already fixed this in another PR. I just need to push a new version. |
|
I took a look just now at the other bug fix |
|
Kudos, SonarCloud Quality Gate passed!
|
Eonasdan
pushed a commit
that referenced
this pull request
Apr 22, 2023
Eonasdan
added a commit
that referenced
this pull request
Apr 22, 2023
* Fix #2788 (#2790) Break if current range-start is clicked to prevent infinite loop * adding placement option (#2789) * fixes #2785 (#2797) * fixes #2785 fixes #2783 fixes #2768 improves docs flow * fixed plugin/locale missing type defs * 2791 more tests (#2800) * validation tests * update datetime tests * "dates" tests * actions tests * fixing infinity loop bug in date range (#2798) * Improvements (#2801) * fixes #2795 * fixes #2784 * fixes #2687 * fixes #2786 * resolves #2764 * fix repl cdn links * fix date range bug * version 6.7.7 * version 6.7.7 --------- Co-authored-by: iTzVirtual_ <[email protected]> Co-authored-by: Killian Hale <[email protected]> Co-authored-by: GitHub User <[email protected]>
|
This was released with 6.7.7 |
Eonasdan
added a commit
that referenced
this pull request
May 22, 2023
* Fix #2788 (#2790) Break if current range-start is clicked to prevent infinite loop * adding placement option (#2789) * fixes #2785 (#2797) * fixes #2785 fixes #2783 fixes #2768 improves docs flow * fixed plugin/locale missing type defs * 2791 more tests (#2800) * validation tests * update datetime tests * "dates" tests * actions tests * fixing infinity loop bug in date range (#2798) * Improvements (#2801) * fixes #2795 * fixes #2784 * fixes #2687 * fixes #2786 * resolves #2764 * fix repl cdn links * fix date range bug * version 6.7.7 * version 6.7.7 --------- Co-authored-by: iTzVirtual_ <[email protected]> Co-authored-by: Killian Hale <[email protected]> Co-authored-by: GitHub User <[email protected]>
Eonasdan
added a commit
that referenced
this pull request
Jul 3, 2023
* Fix #2788 (#2790) Break if current range-start is clicked to prevent infinite loop * adding placement option (#2789) * fixes #2785 (#2797) * fixes #2785 fixes #2783 fixes #2768 improves docs flow * fixed plugin/locale missing type defs * 2791 more tests (#2800) * validation tests * update datetime tests * "dates" tests * actions tests * fixing infinity loop bug in date range (#2798) * Improvements (#2801) * fixes #2795 * fixes #2784 * fixes #2687 * fixes #2786 * resolves #2764 * fix repl cdn links * fix date range bug * version 6.7.7 * version 6.7.7 --------- Co-authored-by: iTzVirtual_ <[email protected]> Co-authored-by: Killian Hale <[email protected]> Co-authored-by: GitHub User <[email protected]>
Eonasdan
pushed a commit
that referenced
this pull request
Jul 3, 2023
Eonasdan
pushed a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developmentbranchWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...). If this is a fix, please tag a bug.
Bug fix.
What is the current behavior? (You can also link to an open issue here)
When dealing with date range and selecting the same date as start/end date it causes an infinite loop and browser crash.
What is the new behavior (if this is a feature change)?
As the problem was because of assuming that end date is always after start date, the start date was being incremented by 1 day before the for loop compare with the end date happens, causing the start date to be after the end date if it was the same day, hence the infinity loop.
The fix separates the increment from the initialization of the start variable and comparing if it's the same before the increment step and the for loop.
No