Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change parent container for the widget v6 feature #2462

Merged
merged 4 commits into from
Jan 15, 2022

Conversation

miniben-90
Copy link
Contributor

@miniben-90 miniben-90 commented Jan 6, 2022

  • Please check if the PR fulfills these requirements
  • The PR is against the development branch
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...). If this is a fix, please tag a bug.
    This is a feature that allows you to change the target container instead of the body element for the widget generation.

  • What is the current behavior? (You can also link to an open issue here)
    The component generate the widget as a append child of body but in shadow DOM it can be problematic in case if the styles not loaded in the main DOM.

  • What is the new behavior (if this is a feature change)?
    Add a new parameter container to define a HTMLElement target instead of body.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Not a breaking change. If the parameter's not defined it'll use body as target.

  • Other information:

@miniben-90 miniben-90 changed the base branch from master to development January 10, 2022 14:38
@Eonasdan Eonasdan merged commit a76aa6c into Eonasdan:development Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants