Compare date types with strongly typed names #2408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many JavaScript frameworks and bundlers minify code when building for production.
Minification includes renaming identifiers, including class names.
Comparing types using literal string names doesn't work well with these frameworks and bundlers.
For example, SvelteKit renames
DateTime
to something likeVe
.With this, the
if
test fails because 'Ve' is not the same as 'DateTime'.This results in exceptions such as the following:
With this change, in the minified file, the line now tests for
Ve.name
instead of 'DateTime'