Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promptTimeOnDateChange option #2630

Closed
usmazat opened this issue Aug 16, 2022 Discussed in #2618 · 7 comments
Closed

promptTimeOnDateChange option #2630

usmazat opened this issue Aug 16, 2022 Discussed in #2618 · 7 comments

Comments

@usmazat
Copy link

usmazat commented Aug 16, 2022

Discussed in #2618

Originally posted by usmazat August 7, 2022
Hi everyone! I'm not sure if it is a bug, or maybe I'm just missing something super obvious here, but I can't get the promptTimeOnDateChange option to work .I tried following simple setup using stackblitz, when I select a date, time portion doesn't popup as it supposedly should. Stackblitz console doesn't show anything, but then I use "open in a new window" link and then open chrome ( version 103.0.5060.134) console I see the following stack trace popup after a select a date

actions.ts:173 Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
   at Actions.do (actions.ts:173:35)
   at actions.ts:31:20
   at event-emitter.ts:21:7
   at Array.forEach (<anonymous>)
   at EventEmitter.emit (event-emitter.ts:20:22)
   at tempus-dominus.ts:459:36
do @ actions.ts:173
(анонимная) @ actions.ts:31
(анонимная) @ event-emitter.ts:21
emit @ event-emitter.ts:20
(анонимная) @ tempus-dominus.ts:459
Объект setTimeout (асинхронный)
_handleAfterChangeEvent @ tempus-dominus.ts:457
_triggerEvent @ tempus-dominus.ts:253
(анонимная) @ tempus-dominus.ts:62
(анонимная) @ event-emitter.ts:21
emit @ event-emitter.ts:20
setValue @ dates.ts:250
do @ actions.ts:105
(анонимная) @ actions.ts:31
(анонимная) @ event-emitter.ts:21
emit @ event-emitter.ts:20
Display._actionsClickEvent @ index.ts:758

the same thing happens in firefox (version 103.0.1 (64-bit))

Uncaught TypeError: currentTarget is null
    do actions.ts:173
    Actions actions.ts:31
    emit event-emitter.ts:21
    emit event-emitter.ts:20
    _currentPromptTimeTimeout tempus-dominus.ts:459

I'm using windows 10 version 21H1. Any Idea what I'm missing here?
The same thing still happens with v6 beta10 (I updated the discussion with correct stackbkitz url) My locale is ru-Ru

@blankse
Copy link
Contributor

blankse commented Nov 22, 2022

I have the same error with this option.

@Eonasdan Eonasdan moved this from 🆕 New to 📋 Backlog in Tempus Dominus Dec 5, 2022
@Eonasdan Eonasdan moved this from 📋 Backlog to 🔖 Ready in Tempus Dominus Dec 5, 2022
@Eonasdan
Copy link
Owner

Eonasdan commented Dec 8, 2022

Hello, please check this StackBlitz.

Disregard

@Eonasdan Eonasdan moved this from 🔖 Ready to 🏗 In progress in Tempus Dominus Dec 8, 2022
@blankse
Copy link
Contributor

blankse commented Dec 8, 2022

@Eonasdan I don't see any promptTimeOnDateChange option in this StackBlitz.

@Eonasdan
Copy link
Owner

Eonasdan commented Dec 8, 2022

Oops! Sorry that was the wrong ticket. I just started working on this one.

Eonasdan added a commit that referenced this issue Dec 8, 2022
@Eonasdan
Copy link
Owner

Eonasdan commented Dec 8, 2022

Seriously though, try this one

@Eonasdan Eonasdan moved this from 🏗 In progress to 👀 In review in Tempus Dominus Dec 8, 2022
@blankse
Copy link
Contributor

blankse commented Dec 8, 2022

@Eonasdan Works for me. Thanks!

@ActionJONA
Copy link

Found the issue.
Line 3871 of: JS

Is:

currentTarget: this.display.widget.querySelector(.${Namespace.css.switch} div),

Should be:

currentTarget: this.display.widget.querySelector(.${Namespace.css.toolbar} div),

@Eonasdan Eonasdan moved this from 👀 In review to ✅ Done in Tempus Dominus Dec 9, 2022
Eonasdan added a commit that referenced this issue Dec 9, 2022
Eonasdan added a commit that referenced this issue Dec 9, 2022
Eonasdan added a commit that referenced this issue Dec 9, 2022
Eonasdan added a commit that referenced this issue Dec 14, 2022
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants