Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frequency domain corrections for nth octave spectrum and screening for tones functions #53

Merged
merged 19 commits into from
May 20, 2022
Merged

Frequency domain corrections for nth octave spectrum and screening for tones functions #53

merged 19 commits into from
May 20, 2022

Conversation

wantysal
Copy link
Collaborator

  • The function noct_synthesis and noct_freq_filter have been enhanced for better accuracy compared to the filtering in time domain. The function butter and sosfreqz from scipy.signal are used.
  • In time domain, the use of a,b filter representation have been replaced by sos to improve the performance of noct_spectrum.
  • The function screening_for_tones has been corrected to correctly detect a potential peak on the first index
  • The function spectrum_smoothing now takes as input a spectrum of dimension (nperseg, nseg) as the rest of the functions

All the tests are running without any warning.

Tks :)

wantysal and others added 18 commits May 16, 2022 13:29
@wantysal
[CC] added noct_synthesis to the init file to import it more easily
e45051e
@wantysal
[CC] nth octave spectrum computation enhanced
1dfdd10
@wantysal
Merge branch 'Eomys:master' into freq_correction
748bfe3
@wantysal
[CC] init file corrected
88fbdde
@wantysal
[CC] output as numpy.array
3a83016
@wantysal
[CC] return low and high frequency of each band on top of the center …
23e70f3 
…frequency
@wantysal
[CC] use sos instead of a,b when building filter for better performance
c413ad9
@wantysal
[CC] using sosfreqz(scipy.signal.butter) for better accuracy on both …
768d71e 
…synthetic and technical signals
@wantysal
[CC] tests update
1f5371f
@wantysal
[CC] tests updated to check the frequencies found in tonality calcula…
d8640fc 
…tion
@wantysal
[CC] spectrum scanning function corrected on the lower boundary frequ…
b02e552 
…ency
@wantysal
[CC] file path update
de33b2f
@wantysal
[CC] useless variables / lines removed
2017ba7
@wantysal
[CC] useless lines removed
08feb9b
@wantysal
[CC] deactivate plot from test
42e30eb
@wantysal
[CC] paths of the test files corrected
a8103c0
@wantysal
Merge branch 'freq_correction' of https://github.com/wantysal/MoSQITooo…
6fec26e 
… into freq_correction
@wantysal
[BC] validation print deleted
6ddfdd3
mglesser
mglesser requested changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@mglesser mglesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are missing output data description in a docstring

mosqito/sound_level_meter/noct_spectrum/_filter_bandwidth.py Show resolved Hide resolved
@mglesser mglesser merged commit 417e772 into Eomys:master May 20, 2022
@mglesser
Copy link
Collaborator

Thank you for your contribution

@wantysal wantysal deleted the freq_correction branch May 20, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglesser mglesser mglesser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wantysal @mglesser