Fixes warnings and adds missing header guards #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Oct 19, 2024
| @@ -739,7 +739,7 @@ void emit_extract_calls(const TGPattern &pattern, raw_ostream &os) { | |||
| } | |||
|
|
|||
| // Will be used by Julia | |||
| SmallString<80> ValueType_helper(const TGPattern &pattern, ssize_t actPos, | |||
| SmallString<80> ValueType_helper(const TGPattern &pattern, size_t actPos, | |||
There was a problem hiding this comment.
This isn't valid since actpos could be negative
There was a problem hiding this comment.
Seemed to not flag after reverting
wsmoses
reviewed
Oct 19, 2024
MattBolitho
force-pushed
the
warnings-and-clang-tidy
branch
from
7d4b4ba
to
a586c74
Compare
wsmoses
approved these changes
Oct 28, 2024
jedbrown
added a commit
that referenced
this pull request
Nov 1, 2024
* main: (49 commits) Fix iv of constant (#2141) Update benchmarks (#2035) Implement tgamma derivative (#2140) tgamma error improvement (#2139) Improve cache index error message (#2138) Fixes warnings and adds missing header guards (#2124) mlir: cache and reuse reverse funcs (#2133) mlir: implement forward mode for func.call (#2134) mlir: Func call reverse diff (#2127) Update build_tarballs.jl Fix combined temp cache for reverse (#2131) Improve runtime activity err message (#2132) Fix undef value storage (#2129) Adapt to const tblgen (#2128) Add gcloaded TT (#2125) Fix blas decl updater indexing (#2123) Add header files to ClangEnzyme target (#2062) Improve unknown function error messages (#2120) Fix handle sync (#2122) Support more Julia 1.11 functions (#2121) ...
jedbrown
added a commit
that referenced
this pull request
Nov 1, 2024
* main: (49 commits) Fix iv of constant (#2141) Update benchmarks (#2035) Implement tgamma derivative (#2140) tgamma error improvement (#2139) Improve cache index error message (#2138) Fixes warnings and adds missing header guards (#2124) mlir: cache and reuse reverse funcs (#2133) mlir: implement forward mode for func.call (#2134) mlir: Func call reverse diff (#2127) Update build_tarballs.jl Fix combined temp cache for reverse (#2131) Improve runtime activity err message (#2132) Fix undef value storage (#2129) Adapt to const tblgen (#2128) Add gcloaded TT (#2125) Fix blas decl updater indexing (#2123) Add header files to ClangEnzyme target (#2062) Improve unknown function error messages (#2120) Fix handle sync (#2122) Support more Julia 1.11 functions (#2121) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should produce no warnings when building with the
alltarget withclang-19