Fewer anonymous funcs and despecialize inference #2131
+194
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
wsmoses
changed the title
vchuravy
reviewed
Nov 30, 2024
|
|
||
| define i64 @f({} addrspace(10)* %obj) readnone alwaysinline { | ||
| %c = addrspacecast {} addrspace(10)* %obj to {} addrspace(11)* | ||
| %r = call {}* @julia.pointer_from_objref({} addrspace(11)* %c) |
vchuravy
reviewed
Nov 30, 2024
| @@ -1,6 +1,6 @@ | |||
| # For julia runtime function emission | |||
|
|
|||
| function emit_allocobj!( | |||
| Base.@nospecializeinfer function emit_allocobj!( | |||
There was a problem hiding this comment.
Can we import Base: @nospecializeinfer?
vchuravy
reviewed
Nov 30, 2024
Comment on lines
-492
to
+498
| for lbb in blocks(initfn), linst in collect(instructions(lbb)) | ||
| for lbb in blocks(initfn) | ||
| liter = LLVM.API.LLVMGetFirstInstruction(lbb) | ||
| while liter != C_NULL |
There was a problem hiding this comment.
Why not simply for linst in instructions(lbb)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.