Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technospheres, dental clinics, and facilities - oh my! #1544

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pbuttigieg
Copy link
Member

Resolves #1538

@pbuttigieg pbuttigieg self-assigned this Oct 7, 2024
@pbuttigieg pbuttigieg linked an issue Oct 7, 2024 that may be closed by this pull request
@@ -6086,10 +6086,10 @@ SubClassOf(<http://purl.obolibrary.org/obo/ENVO_00000069> <http://purl.obolibrar
AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "MA:ma") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_00000070> "A construction that has been assembled by deliberate human effort.")
AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000116> <http://purl.obolibrary.org/obo/ENVO_00000070> "\"constructed\" should probably be made something like a quality and this class obsoleted or filled only by inference")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <http://purl.obolibrary.org/obo/ENVO_00000070> "constructed feature")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_00000070> "Some human constructions (such as extra planetary probes like the Voyager mission) exist outside of Earth's technosphere, and are thus not astronomical body parts. Assertions regarding whether a construction is part of the technosphere of an astronomical body (i.e. Earth) should be made at the instance level, if needed."@en)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_00000070> "Some human constructions (such as extra planetary probes like the Voyager mission) exist outside of Earth's technosphere, and are thus not astronomical body parts. Assertions regarding whether a construction is part of the technosphere of an astronomical body (i.e. Earth) should be made at the instance level, if needed."@en)
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_00000070> "Some human constructions (such as the extra planetary probes build for the Voyager missions) exist outside of Earth's (or any other astrononomical body's) technosphere, and are thus not astronomical body parts. Assertions regarding whether a construction is part of the technosphere of an astronomical body (e.g. Earth) should be made at the instance level, if needed / useful for the application case."@en)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't commit this, due to this bug
https://github.com/orgs/community/discussions/43052

Will edit manually and then resolve this

Copy link
Member Author

@pbuttigieg pbuttigieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment edits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope of 'astronomical body part'
2 participants