updating sssom file with metadata #162
Conversation
|
this sssom files seems tiny.. There should be thousands of matches in there? |
|
This was done manually by me based on the mappings that Bill did. I hear that a conversion from boomer output to SSSOM is in the works. In the meantime, I just grabbed the exact matches and this was all I could find. Maybe there is another file somewhere? |
|
If these are manual mappings, that seems fine. I don't understand the ECTO mapping framework well enough, but my sense is that we need some kind of overarching ECTO mapping file that includes all mappings to external ontologies - which should be in the higher hundreds.. |
|
another issue is that this was run when ECTO was very small. Prob needs to be run again now that there are way more classes. |
|
If you are happy with the removal of the licensing column, I can go ahead and merge this PR |
|
addresses issue #117 |
|
Need some time to think about this one, not sure how it's related to the automated mappings |
|
Hey @diatomsRcool I believe we can remove this file now, as I think its redundant with https://github.com/EnvironmentOntology/environmental-exposure-ontology/blob/master/mappings/ecto.sssom.tsv Was this file here originally created automatically? its a bit odd that some stuff that was matched here is not anymore matched in the new run, but maybe there are good explanations for this. Where did the ecto-exact-001.tsv orginially come from? If its automated pipeline, you can close this pull request (without merging) and delete the file. |
|
The ecto-exact-001.tsv was literally made my me with my own 10 fingers on the keyboard. I just wanted to get something in sssom format. I will close this PR. |
|
Hmm, maybe we need this in the end.. I will move it somewhere else. |
Added metadata to the sssom file:
mapping_tool
mapping_date
creator_id
license